Auth, UI: Visually updated StepIndicator component, open terms in new tab #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,7 +163,7 @@ const LoginPanel: React.FC<PropsWithChildren & { | |||
| <ProviderLoginButton provider='github' isLoading={isLoading} loginWithProvider={loginWithProvider}> | |||
| <GitHub height={20}/>Github | |||
| </ProviderLoginButton> | |||
| <p className='text-sm text-muted-2'>By logging in, you agree to our <Link href={termsOfServiceUrl ?? ''}>Terms of Service</Link> and <Link href={privacyPolicyUrl ?? ''}>Privacy Policy</Link>.</p> | |||
| <p className='text-sm text-muted-2'>By logging in, you agree to our <Link href={termsOfServiceUrl ?? ''} target='_blank'>Terms of Service</Link> and <Link href={privacyPolicyUrl ?? ''} target='_blank'>Privacy Policy</Link>.</p> | |||
There was a problem hiding this comment.
@erikrakuscek This may seem like the opposite of what I say about using Blocks, but why not just put a LinkElement there? What's why I create them: as a convenient wrapper around links that can be predefined. Not worth changing since this is "on off" but just keep it in mind goign foward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires bump of @hanzo/auth and @hanzo/ui